Feature/pratyush1718/counselor get route #67
+72
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Miyuki-L
reviewed
Feb 25, 2025
backend/src/app.ts
Outdated
|
|
||
|
|
||
| const app: Express = express(); | ||
| const port = process.env.PORT ?? 3000; |
There was a problem hiding this comment.
set the default port to 3001, 3000 is where frontend is running
backend/src/app.ts
Outdated
|
|
||
| app.use(express.json()); | ||
|
|
||
| app.use("/api/user", userRoutes); |
There was a problem hiding this comment.
add the other routes that were added in the old index.ts file as well. They should have already been merged into main
backend/src/controllers/user.ts
Outdated
| @@ -58,6 +60,15 @@ export const getAllUsers = (_req: Request, res: Response) => { | |||
| } | |||
| }; | |||
|
|
|||
| export const getAllCounselors: RequestHandler = async (_req, res, next) => { | |||
There was a problem hiding this comment.
get all members.
I forgot for this route we intend to just get all members.
Designers chagned the wording from counselors to member
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking Info
Resolves #49
Changes
Added a counselor route/controller to get counselor information to populate counselor table. Also added 2 dummy documents in our mongodb user collection to test with.
MISC: also merged index.ts and app.ts into one file (app.ts under the src folder)
Testing
Postman testing
Confirmation of Change